This commit should fix issue AHC-116 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfarcand
added a commit
that referenced
this pull request
Oct 25, 2011
This commit should fix issue AHC-116
|
Nice catch, thanks. In 1.7. |
|
But that will pass the check now if it is actually null. (And also it's not guaranteed that == will always work, it could be a different String instance of "".) The safer check would be: |
|
Hey, My bad, too many Scala development lately... forgot that == was NOT equals in Java :p |
|
@jeffstyr, I've made the modification in a new pull request :-) thanks for your correction ;-) |
|
Eurr...completely missed that as well. Will take a look at your last pull. Thanks! |
|
No problem. And yeah, Scala does peculiar things to one's brain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now proxyServer.getNtlmDomain() is tested for inequality with "" instead of null.
Indeed, it is defined as private String ntlmDomain = System.getProperty("http.auth.ntlm.domain", ""); in ProxyServer.java.