Streamwrapper: Move logic out into the open #4595
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahum
force-pushed
the
move/VIP_FILESYSTEM_USE_STREAM_WRAPPER
branch
from
f336520
to
cc267ae
Compare
rebeccahum
force-pushed
the
move/VIP_FILESYSTEM_USE_STREAM_WRAPPER
branch
from
cc267ae
to
3daa544
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## develop #4595 +/- ##
==========================================
Coverage 29.12% 29.12%
Complexity 4704 4704
==========================================
Files 276 276
Lines 20751 20751
==========================================
Hits 6044 6044
Misses 14707 14707
|
|
This flips the logic and may result in breakage in Local Dev Env which didn't have the stream wrapper constant. This is being addressed here: Automattic/vip-container-images#517 But even when that's merged we don't update wp-config for existing environments. |
rebeccahum
force-pushed
the
move/VIP_FILESYSTEM_USE_STREAM_WRAPPER
branch
from
2260228
to
3824c48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #4589, we should move this logic out into the open since it is already enabled for everyone. There is still the option to disable it with the constant
VIP_FILESYSTEM_USE_STREAM_WRAPPERthough.