Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates automattic\rewrite-rules-inspector to v1.4.0 #5601

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

brunobasto
Copy link
Contributor

@brunobasto brunobasto commented May 21, 2024

Description

Starting point PR to update update/rewrite-rules-inspector to v1.4.0. I'm not sure we need to update other files as well.

Still not sure how to test it.

Changelog Description

Changed

  • Updated update/rewrite-rules-inspector to version 1.4.0

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (5da5aef) to head (14400b4).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5601      +/-   ##
=============================================
+ Coverage      29.52%   29.54%   +0.01%     
  Complexity      4780     4780              
=============================================
  Files            282      282              
  Lines          20577    20565      -12     
=============================================
  Hits            6076     6076              
+ Misses         14501    14489      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rinatkhaziev
Copy link
Contributor

Thanks @brunobasto

You can either use the Dev Env or using the Codespaces:
image

@brunobasto
Copy link
Contributor Author

brunobasto commented May 23, 2024

I was able to run locally, and logging REWRITE_RULES_INSPECTOR_VERSION returns the new version:

Screenshot 2024-05-23 at 13 47 27

Visually they look the same I think:

Screenshot 2024-05-23 at 13 47 15

@GaryJones
Copy link
Contributor

Visually they look the same I think

Correct - https://github.com/Automattic/Rewrite-Rules-Inspector/releases/tag/1.4.0 is the small list of changes.

@brunobasto brunobasto marked this pull request as ready for review May 24, 2024 18:25
@brunobasto brunobasto requested a review from a team as a code owner May 24, 2024 18:25
@rebeccahum rebeccahum merged commit 086fd01 into develop Jun 3, 2024
39 checks passed
@rebeccahum rebeccahum deleted the update/rewrite-rules-inspector branch June 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants