Update README.md #5
Conversation
|
No issues were found in this pull request. |
|
No issues were found in this pull request. |
README.md
Outdated
| * Open it in Visual Studio and install the latest version of dependent NuGet packages (e.g. Microsoft.IdentityModel.Clients.ActiveDirectory) | ||
| * Create (or use and existing) Azure Active Directory Application ID and the corresponding information. If you do not have one and need instructions on how to get one, you can check [here](https://docs.microsoft.com/en-us/rest/api/datacatalog/register-a-client-app) | ||
| * Compile the app. | ||
| * You are now ready to run it. |
There was a problem hiding this comment.
Please see my comments the equivalent to lines 13-16 above in Azure-Samples/data-catalog-dotnet-get-started#10
README.md
Outdated
| This sample shows you how to bulk register and annotate data assets from an Excel workbook using the Data Catalog REST API and Open XML. | ||
|
|
||
| To get started using this sample, you first need to build the executable, following below steps: | ||
| * Download the sample project |
There was a problem hiding this comment.
It would be helpful to give the GIT command they can use to do that.
There was a problem hiding this comment.
This is By Design. I feel this would be very basic for the developer audience here. I'm also following the practice used in https://azure.microsoft.com/en-us/resources/samples/data-catalog-dotnet-import-export/
There was a problem hiding this comment.
Many enterprise developers never work with Git or work with a single repo that they don't have to clone more than once. So by not adding a single line we force the enterprise dev to wonder "Um... how do I do that download? What was the command line for that? Oh wait can GitHub do it for me? I don't remember!" or we can add "git clone https://github.com/Azure-Samples/data-catalog-dotnet-excel-register-data-assets.git" and be done with it. Please help me understand what harm it would do to include this sentence and how that harm would outweigh the benefits?
README.md
Outdated
| This sample shows you how to register and annotate data assets from an Excel workbook. | ||
| This sample shows you how to bulk register and annotate data assets from an Excel workbook using the Data Catalog REST API and Open XML. | ||
|
|
||
| To get started using this sample, you first need to build the executable, following below steps: |
There was a problem hiding this comment.
/sample, you/sample you/ - No comma because there aren't two separate thoughts.
/executable,/executable/ - Again, no command. Thoughts aren't being separated.
README.md
Outdated
| @@ -6,4 +6,11 @@ author: dvana | |||
|
|
|||
| # Azure Data Catalog - Bulk register and annotate | |||
|
|
|||
| This sample shows you how to register and annotate data assets from an Excel workbook. | |||
| This sample shows you how to bulk register and annotate data assets from an Excel workbook using the Data Catalog REST API and Open XML. | |||
There was a problem hiding this comment.
/the Data Catalog/the Azure Data Catalog/
|
No issues were found in this pull request. |
|
No issues were found in this pull request. |
Adding guidance on installing the updated NuGet packages