Fix message order issue for management SDK #1801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicancy
reviewed
Jun 27, 2023
| var connectionUsed = await WriteWithRetry(serviceMessage, _inUseConnection, currentConnections, IterateConnectionsInFixedOrder); | ||
| // Similarly, here is currently no synchronization when persisting selected connection in _inUseConnection. | ||
|
|
||
| if (connectionUsed != _inUseConnection) |
There was a problem hiding this comment.
check+set is not atomic, maybe simply set
| @@ -515,22 +516,21 @@ private async Task WriteToScopedOrRandomAvailableConnection(ServiceMessage servi | |||
| } | |||
| else | |||
| { | |||
| await WriteWithRetry(serviceMessage, null, currentConnections); | |||
| var connectionUsed = await WriteWithRetry(serviceMessage, _inUseConnection, currentConnections, IterateConnectionsInFixedOrder); | |||
There was a problem hiding this comment.
so it changes the current behavior that the traffic distributes to random connections for proxy mode. is using random connections enough?
| } | ||
| } | ||
| iterator ??= iterateConnections(currentConnections).GetEnumerator(); | ||
| connection = iterator.MoveNext() ? iterator.Current : throw new ServiceConnectionNotActiveException(); |
There was a problem hiding this comment.
using do.. while(iterator.MoveNext()) pattern?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.