Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Captions] captions adhoc #4579

Merged
merged 17 commits into from May 8, 2024
Merged

[Captions] captions adhoc #4579

merged 17 commits into from May 8, 2024

Conversation

dmceachernmsft
Copy link
Member

What

add state to track whether something is a teams meeting or a teams call

Why

Allows for the use of captions in click to call scenarios

How Tested

Validated locally

@dmceachernmsft dmceachernmsft requested review from a team as code owners May 6, 2024 16:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-rumbgjatxt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

Calling bundle size is increased❗.

  • Current size: 4891029
  • Base size: 4889834
  • Diff size: 1195

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

Chat bundle size is not changed.

  • Current size: 2182328
  • Base size: 2182328
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

CallWithChat bundle size is increased❗.

  • Current size: 6317152
  • Base size: 6315859
  • Diff size: 1293

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-iadjfkowxp.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-ycqllpzlyh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-qrtolcvous.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-kingcjzaqn.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25446 / 39377
64.62%		 25446 / 39377
64.62%		 699 / 1233
56.69%		 2018 / 3205
62.96%
Current 25368 / 39377
64.42%		 25368 / 39377
64.42%		 699 / 1233
56.69%		 2019 / 3206
62.97%
Diff -78 / 0
-0.2%		 -78 / 0
-0.2%		 0 / 0
0%		 1 / 1
0.01%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49966 / 79545
62.81%		 49966 / 79545
62.81%		 1038 / 2303
45.07%		 2922 / 4784
61.07%
Current 49972 / 79630
62.75%		 49972 / 79630
62.75%		 1039 / 2305
45.07%		 2905 / 4782
60.74%
Diff 6 / 85
-0.06%		 6 / 85
-0.06%		 1 / 2
0%		 -17 / -2
-0.33%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-wobkfgjark.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-pquxcnhbqh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-bspqusmqjw.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-cbthmwwlge.chromatic.com/

@dmceachernmsft dmceachernmsft merged commit fd4a6aa into main May 8, 2024
41 checks passed
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/captions-adhoc branch May 8, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carocao-msft carocao-msft carocao-msft approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@carocao-msft carocao-msft

@edwardlee-msft edwardlee-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmceachernmsft @carocao-msft @edwardlee-msft