Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getRequestAuthorityWithExtraQP in AdalBrokerRequestAdapter #436

Open
kreedula opened this issue Mar 26, 2019 · 1 comment
Open

Refactor getRequestAuthorityWithExtraQP in AdalBrokerRequestAdapter #436

kreedula opened this issue Mar 26, 2019 · 1 comment
Labels
Enhancement This is a feature request to add functionality that is not currently supported Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue

Comments

@kreedula
Copy link
Contributor

The logic here looks into extra QP and checks for slice/dc and will ad to Authority and removes those extra QP params. Seems a bit rough, and there is scope to improve it. https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/433/files/846df27508abe92e6fd55de4f050aece61236956#diff-3bceaa5e3e93d643181941a6c0daa0d0R256
@kreedula kreedula mentioned this issue Mar 26, 2019
Merged
@iambmelt iambmelt added Enhancement This is a feature request to add functionality that is not currently supported Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue labels Dec 19, 2019
@iambmelt
Copy link
Member

iambmelt commented Aug 6, 2021

Removing the assignee as they are no longer contributing to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement This is a feature request to add functionality that is not currently supported Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iambmelt @kreedula