Msal - Broker changes #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
March 17, 2019 19:32
…reAD/microsoft-authentication-library-common-for-android into kreedula/msal-broker-changes
…reAD/microsoft-authentication-library-common-for-android into kreedula/msal-broker-changes
…reAD/microsoft-authentication-library-common-for-android into kreedula/msal-broker-changes
…reAD/microsoft-authentication-library-common-for-android into kreedula/msal-broker-changes
heidijinxujia
suggested changes
Mar 26, 2019
common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerRequest.java
Outdated
Show resolved
Hide resolved
iambmelt
reviewed
Mar 26, 2019
common/src/main/java/com/microsoft/identity/common/internal/broker/PackageHelper.java
Show resolved
Hide resolved
iambmelt
reviewed
Mar 26, 2019
...n/src/main/java/com/microsoft/identity/common/internal/request/AdalBrokerRequestAdapter.java
Show resolved
Hide resolved
iambmelt
reviewed
Mar 26, 2019
.../microsoft/identity/common/internal/request/BrokerAcquireTokenSilentOperationParameters.java
Outdated
Show resolved
Hide resolved
iambmelt
reviewed
Mar 26, 2019
...rc/main/java/com/microsoft/identity/common/internal/request/BrokerRequestAdapterFactory.java
Outdated
Show resolved
Hide resolved
iambmelt
reviewed
Mar 26, 2019
| @@ -0,0 +1,231 @@ | |||
| package com.microsoft.identity.common.internal.request; | |||
iambmelt
reviewed
Mar 26, 2019
common/src/main/java/com/microsoft/identity/common/internal/request/OperationParameters.java
Show resolved
Hide resolved
iambmelt
approved these changes
Mar 26, 2019
| @@ -41,6 +41,9 @@ | |||
| @SerializedName("correlation_id") | |||
| private String mCorrelationId; | |||
|
|
|||
| @SerializedName("oAuth_metadata") | |||
| private String mOAuthErrorMetadata; | |||
There was a problem hiding this comment.
Curious. Any example of error metadata?
There was a problem hiding this comment.
I think currently we don't get any, but eventually we would I guess, just moved this from BrokerErrorResponse
...oft/identity/common/internal/providers/microsoft/microsoftsts/MicrosoftStsTokenResponse.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public BrokerAcquireTokenOperationParameters brokerInteractiveParametersFromActivity(@NonNull final Activity callingActivity) { |
There was a problem hiding this comment.
Are these all moved from ad-accounts' BrokerUtil? Is there any extra change you made in this PR?
There was a problem hiding this comment.
Moved and refactored with some changes as deemed appropriate. Anything suspicious?
...n/src/main/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapter.java
Show resolved
Hide resolved
…reAD/microsoft-authentication-library-common-for-android into kreedula/msal-broker-changes
…reAD/microsoft-authentication-library-common-for-android into kreedula/msal-broker-changes
|
Thanks @iambmelt @heidijinxujia for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ad-accounts PR : https://github.com/AzureAD/ad-accounts-for-android/pull/911
msal PR : AzureAD/microsoft-authentication-library-for-android#550