[Fix] enable custom fragment logic #1672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VansonLeung
requested review from
rpdome,
shahzaibj and
shoatman
as code owners
|
|
|
@rpdome - Please review when you have a chance. I'll take a look today. Thanks |
|
There seems to be an existing method to set the state; however it does not appear be used currently. getAuthorizationFragmentFromStartIntentWithState (found in AuthorizationActivityFactory) |
|
It does not appear that end users could directly use this function publicly and it was not documented either. I am not sure the use of this function. Unless someone has figured out what is for - I think my fix is not a dirty fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom fragment logic should fulfill the intent bundle parameters
Otherwise the fragment will destroy itself immediately after auth creation, thus rendering this function useless.
Related issue: #1669