Skip to content
This repository has been archived by the owner on Aug 15, 2022. It is now read-only.

Thread safety and stop messages returning to pool too early #405

Open
wants to merge 2 commits into
base: alloy
Choose a base branch
from

Conversation

zaddo67
Copy link

@zaddo67 zaddo67 commented May 25, 2021

  • Messages added back to pool while still active in message bus stored messages and repeater lists.
  • Make MessagePoolMulti thread safe as it is called from alloy networking thread and main thread
  • Make BMSBytePool thread safe
  • Two of the SendReliableMessage methods in ForgeNetworkMediator were not sending reliably
  • ForgeUDPSocketServerFacade ChallengeSuccess assumed challenged players still exists in list. Changed to check entry exists. (Might be an issue unique to my project, ok to ignore unless you have same issue)
  • Helper method in ForgeMessageCodes to instantiate message from message type (Can be ignored)
  • Helper Method in IPlayerRepository to check if player signature exists (Can be ignored)

Please note that these changes have not been tested outside of my project. So use appropriate caution if you grab them.

…d messages and repeater lists.

- Make MessagePoolMulti thread safe as it is called from alloy networking thread and main thread
- Make BMSBytePool thread safe
- Two of the SendReliableMessage methods were not sending reliably
- ForgeUDPSocketServerFacade ChallengeSuccess assumed challenged players still exists in list. Changed to check entry exists. (Might be an issue unique to my project, ok to ignore unless you have same issue)
- Helper method in ForgeMessageCodes to instantiate message from message type (Can be ignored)
- Helper Method in IPlayerRepository to check if player signature exists (Can be ignored)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant