Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add commandline options of editor file and svg output #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Jan 25, 2023

After #186

Addressing my own comment: #152 (comment)

@facontidavide
Copy link
Contributor

does this include all the changes in #152 too?

@Timple
Copy link
Contributor Author

Timple commented Feb 1, 2023

#152 was an issue, so technically there were no changes.

But yes, the saveSvgFile was based on the suggestion there.

@facontidavide
Copy link
Contributor

I will merge it after a brief review. Thanks!

@facontidavide facontidavide self-assigned this Feb 1, 2023
@Timple
Copy link
Contributor Author

Timple commented May 12, 2023

This branch went out of date. I rebased it.

@Timple
Copy link
Contributor Author

Timple commented Jun 9, 2023

Now that #186 has been merged (thank you) this one can have a go as well.

It's especially useful for automating the documentation process. Like in pre-commit hooks or CI actions like this:

rosrun groot Groot --mode editor --file=behavior_tree.xml --output-svg doc/behavior_tree.svg

If you like I can add this hint/tip to the Readme.

@Timple
Copy link
Contributor Author

Timple commented Mar 22, 2024

subtle ping 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants