Correct ensure_buffered_data
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 92.56% 93.37% +0.80%
==========================================
Files 2 3 +1
Lines 296 302 +6
==========================================
+ Hits 274 282 +8
+ Misses 22 20 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
It appears that the number of threads allowed in CI is capped at 2.
Displays the number of threads in used when testing.
CiaranOMara
force-pushed
the
hotfix/ensure_buffered_data
branch
from
c1d7e51
to
8a5369c
Compare
CiaranOMara
force-pushed
the
hotfix/ensure_buffered_data
branch
from
8a5369c
to
886d474
Compare
The `read_blocks!` function does not necessarily fill/overwrite blocks till `lastindex(stream.blocks)`, we need to ensure `stream.block_index` does not increment past the index of the last loaded block.
CiaranOMara
force-pushed
the
hotfix/ensure_buffered_data
branch
from
886d474
to
6bc27f9
Compare
|
The downstream error in Geneticvariation.jl is related to minhash, not BGZFStreams.jl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
read_blocks!function does not necessarily fill/overwrite blocks tilllastindex(stream.blocks), we need to ensurestream.block_indexdoes not increment past the index of the last loaded block.