Bitshala Bitcoin Core PR Review Club

This is a PR review club organized by Bitshala, with inspiration from Bitcoin Core Reviews.

This club is organized biweekly on Thursday at IST 20:00 (UTC 14:30) and is open to all. Joining link for the jitsi room is shared in the #announcements channel of Bitshala Discord. (the "location" in the Event Card). For event reminders, subscribe to our Google Calendar or add this ICS file to whichever calendar application you're using.

PR review is the easiest way to get into the weeds of Bitcoin Core Development. While the IRC review club is the go-to place for existing Core devs, it can be intimidating for newcomers. For such reason, this club is organized to facilitate ad-hoc and loosely following discussions over a live call for an hour. So if you are an aspiring young dev and are a bit disoriented on how to get started with Bitcoin development, do consider joining our club.

Participating with video isn't mandatory. The calls will be recorded and published for educational purpose

Index:

• Bitshala Bitcoin Core PR Review Club
• Next Review Club
• How To Participate
• Prerequisites
  • Basics
  • Further Reading
• Previous Review Club

Next Review Club

• Date: 11 April 2024
• Title: TBA
• PR Details: TBA

How To Participate

• Keep an eye on this README to find weekly updates.
• Join the Bitshala Discord, where PR-related discussions take place. Jitsi link for joining the call will be shared there.
• Each Week's topic detail is included in an Issue. Use the issue comments to post questions and discussions regarding the PR or review process in general.
• The review process starts by checking out the PR and going through the Notes and Questions included in the topic details.
• Prepare your answers before joining the call. There can be many right answers, but there are no stupid questions.
• Join in the jitsi room at the scheduled time and participate in the conversation.
• Submit your final review to the original Bitcoin Core PR thread.

Prerequisites

If you are a first-time participant or haven't reviewed Core PRs before, you will find the following resources helpful.

Basics

• Common operational steps of Core review Process: youtube Code available here
• Bitcoin Core Codebase Introductory Tour: youtube

Further Reading

• Contributing to Bitcoin Core: doc
• Developer Notes: doc
• Intro to Bitcoin Core Dev: doc
• Contributing to Bitcoin Core, a personal account: doc
• Onboarding to Bitcoin Core: doc
• From “Hello World” to Bitcoin Core: doc

Previous Review Club

index	date	PR notes/discussions	video	tag
29	28 March 2024	v27.0 testing		testing guide
28	14 March 2024	follow up ideas for p2p: Allow whitelisting manual connections #27114		p2p net whitelist
27	22 Feb 2024	follow up ideas for test: Fix SegwitV0SignatureMsg nLockTime signedness #29400		good first issue test locktime
26	8 Feb 2024	rpc: parse legacy pubkeys consistently with specific error messages #28336		test rpc
25	25 Jan 2024	test: p2p: check disconnect due to lack of desirable service flags #29279		test p2p
24	4 Jan 2024	test: Use test framework utils in functional tests #28528	link	test util
23	21 Dec 2023	refactor: share and use GenerateRandomKey helper #28455	link	test refactor
22	07 Dec 2023	[Part 2/2] Functional tests for v2 P2P encryption #24748	link	test p2p
21	16 Nov 2023	[Part 1/2: Introduction] Functional tests for v2 P2P encryption #24748	link	test p2p
20	07 Sep 2023	net: transport abstraction	link	p2p
19	24 Aug 2023	crypto: more Span<std::byte> modernization & follow-ups	link	crypto modern c++
18	03 Aug 2023	Silent Payments: Implement BIP352		wallet silent-payment
17	20 July 2023	Miniscript support in Output Descriptors #24148 (Part 2)	link	wallet miniscript descriptor
16	06 July 2023	Miniscript support in Output Descriptors #24148 (Part 1)	link	wallet miniscript descriptor
15	22 June 2023	BIP-325: Signet [consensus] #18267	link	consensus Signet validation tests
14	8 June 2023	Introduce secp256k1 module with field and group classes to test framework #26222	link	crypto functional test framework
13	25 May 2023	Add importmempool RPC #27460		rpc mempool
12	18 May 2023	When a block is disconnected, update transactions that are no longer conflicted #27145	link	wallet
11	13 April 2023	Skip netgroup diversity of new connections for tor/i2p/cjdns #27374	link	p2p netgroup
10	6 April 2023	Add Single Random Draw as an additional coin selection algorithm #17526	link	wallet coin selection
9	23 March 2023	Allow whitelisting outgoing connections #27114	link	p2p whitelist
8	16 March 2023	Add foreign_outputs metadata to support CoinJoin transactions #25991	link	wallet coinjoin
7	9 March 2023	Activation logic for testing consensus changes #16	link	bitcoin inquisition consensus soft forks
6	23 Feb 2023	Prevent block index fingerprinting by sending additional getheaders messages #24571		p2p fingerprinting
5	16 Feb 2023	Track AddrMan totals by network and table, improve precision of adding fixed seeds #26847	link	p2p addrman
4	9 Feb 2023	Add 'sendall' RPC née sweep #24118	link	wallet RPC
3	26 Jan 2023	Reduce resource usage for inbound block-relay-only connections #22778		p2p
2	19 Jan 2023	Manual block-relay-only connections with addnode #24170	link	p2p rpc
1	12 Jan 2023	Add coverage for dust mempool policy (-dustrelayfee setting) #26631		test mempool