Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore charset AST #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore charset AST #72

wants to merge 1 commit into from

Conversation

vectart
Copy link

@vectart vectart commented Aug 17, 2015

If CSS begins with charset, bless fails.

@charset "UTF-8";

@paulyoung
Copy link
Contributor

Thanks @vectart!

@BlessCSS/contributors - it would be great to have everything in that switch statement where we return 0 represented in the tests (if not already) to give some confidence with those.

@mtscout6
Copy link
Member

@vectart Can you add some tests that cover this so we don't regress on it in the future? This is per our Contributing Guide.

@paulyoung
Copy link
Contributor

Relates to #86. It seems like we can't simply ignore @charset.

@makque makque mentioned this pull request Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants