This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Implement bbs_database download
for biorxiv and medrxiv
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify get_daterange_list
Implement get_s3_urls
pafonta
reviewed
Nov 30, 2021
Only list .meca files
Pass around a bucket instance
When I try the dry-run example it sill asks me for my AWS credentials and when I enter random characters I get the (expected) error:
Is it possibly to do a dry-run without credentials or not at all? |
Unfortunately, you have to have the credentials even for the dry run. Why? Well, to do the dry run one needs to send a request to the AWS server and that requires authentification. |
Stannislav
reviewed
Dec 6, 2021
Stannislav
approved these changes
Dec 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
Description
Implements the download logic for
biorxiv
andmedrxiv
.How to test?
Note that the entrypoints will ask you to enter the credentials!
To run the dry run
To run an actual download
Checklist
(if it is not the case, please create an issue first).
(if needed)
whatsnew.rst
updated.(if needed)
setup.py
andrequirements.txt
updated with new dependencies.(if needed)
(if a function is added or modified)