Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct yaml frontmatter end tag #68

Merged
merged 4 commits into from Mar 17, 2024

Conversation

hougesen
Copy link
Contributor

@hougesen hougesen commented Mar 16, 2024

I have changed the yaml frontmatter endtag from ... to --- and added a newlines_after_metadata option.

Both frontmatter endtags were also missing a \n which I have added.

newlines_after_metadata defaults to 1 because it is the value used by prettier.

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's great work right there - thanks a lot!

tests/fmt.rs Outdated
}

#[test]
fn toml_zero_newline() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the *_zero_newline tests are included in *_frontmatter_should_supported_newline_option, so it's probably OK to remove them.

I will do minor refactoring before merging.

- simplify tests
- document new option field
@Byron Byron merged commit 834c74b into Byron:main Mar 17, 2024
1 check passed
@Byron
Copy link
Owner

Byron commented Mar 17, 2024

The new release is now available: https://github.com/Byron/pulldown-cmark-to-cmark/releases/tag/v13.0.0

@hougesen hougesen deleted the fix/correct-yaml-endtag branch March 17, 2024 08:35
@hougesen hougesen restored the fix/correct-yaml-endtag branch March 18, 2024 18:31
@hougesen hougesen deleted the fix/correct-yaml-endtag branch March 18, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants