This repository has been archived by the owner on Nov 15, 2018. It is now read-only.
Add basic edit/update functionality to Profiles
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds both `html` and `js` responses allowing the editting/updating of `first_name`, `last_name`, & `location` on a users profile. Introduces the `profile.edit` & `profile.edit.others` permissions. Removes the `Rail/HttpPositionalArguments` Cop from `rubocop`, this is due to the fact that we're using `rails-4.2.7.1` and that cop is intended to catch behaviour that was deprecated in this [PR](rails/rails#18323) however that deprecation does not affect our current `rails` version.
|
NOTE: The specs for |
JAPTaylor
approved these changes
Dec 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds both
htmlandjsresponses allowing the editting/updating offirst_name,last_name, &locationon a users profile.Introduces the
profile.edit&profile.edit.otherspermissions.Removes the
Rail/HttpPositionalArgumentsCop fromrubocop, this isdue to the fact that we're using
rails-4.2.7.1and that cop isintended to catch behaviour that was deprecated in this PR
however that deprecation does not affect our current
railsversion.Closes #13