Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit gmp to double conversion failures #8087

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pentacular
Copy link
Contributor

Please use the following template to help us managing pull requests.

Summary of Changes

Trivial fix for errors in compiling isotropic remeshing using gmp which fails to convert implicitly to double.

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

@janetournois
Copy link
Member

@sloriot would it make sense to add a test that checks that isotropic remeshing compiles with GMP?

@sloriot
Copy link
Member

sloriot commented Mar 22, 2024

do you think it would work to have double -> FT? From what I remember we said it would not be a good idea. Note also that with a specific vertex point map (on-the-fly conversion), this patch would not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants