Making the Spherical Guassian-map polyhedron a proper model of FaceGraph #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@efifogel does it make sense to have a test compiling it, just to make sure it is not broken at some point? |
|
Sure, I'll add one.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Mon, 22 Apr 2024 at 09:41, Sebastien Loriot ***@***.***> wrote:
@efifogel <https://github.com/efifogel> does it make sense to have a test
compiling it, just to make sure it is not broken at some point?
—
Reply to this email directly, view it on GitHub
<#8153 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOHFDOJSPWMZYLAZLQDY6SWJTAVCNFSM6AAAAABGQSOSP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGYYDGMBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…m_polyhedron_3, which makes the Polyhedron atype a model of the FaceGraph concept
|
ok, did that (added some code to test that it compiles).
PS, in the near future I plan to submit a new feature (or at least a small
feature) that publishes this code (Gaussian map, a.k.a. normal diagram, of
a convex polyhedron).
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Mon, 22 Apr 2024 at 10:41, Efi Fogel ***@***.***> wrote:
Sure, I'll add one.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
On Mon, 22 Apr 2024 at 09:41, Sebastien Loriot ***@***.***>
wrote:
> @efifogel <https://github.com/efifogel> does it make sense to have a
> test compiling it, just to make sure it is not broken at some point?
>
> —
> Reply to this email directly, view it on GitHub
> <#8153 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABVBNOHFDOJSPWMZYLAZLQDY6SWJTAVCNFSM6AAAAABGQSOSP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGYYDGMBSGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
sloriot
added
Batch_1
|
Successfully tested in CGAL-6.0-Ic-235 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The old code does not compile.
While the interface is not published, people may still search and find this piece of code, so better have it right.
Release Management