Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session IDs are not always recreated when logging out under PHP 5 #4282

Merged
merged 2 commits into from May 26, 2021
Merged

Session IDs are not always recreated when logging out under PHP 5 #4282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b28623
Fixed: session fixation issue
ddb4github May 25, 2021
d554749
Update CHANGELOG for PR#4282
ddb4github May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@ Cacti CHANGELOG
1.2.18
-security#4261: Lack of escaping on file input fields can lead to XSS exposure under midwinter theme
-security#4276: Lack of escaping on parameter graph_nolegend can lead to XSS exposure in graph_realtime.php
-security#4282: Regenerate session id to avoid session fixation issue
-issue#4254: When poller first runs, time since last run produces an error
-issue#4259: A typo in variables.php leads to SQL error
-issue#4263: Percentile not showing on partial data after fix for #3340
Expand Down
2 changes: 2 additions & 0 deletions include/csrf.php
View file
Open in desktop
Expand Up @@ -21,6 +21,8 @@ function csrf_startup() {
}

function csrf_error_callback() {
//Resolve session fixation for PHP 5.4
session_regenerate_id();
raise_message('csrf_timeout');
ob_end_clean();
header('Location: ' . sanitize_uri($_SERVER['REQUEST_URI']));
Expand Down