Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing guards after argparse for bad arg combinations #211

Closed
2 of 3 tasks
madeddy opened this issue Apr 1, 2024 · 1 comment
Closed
2 of 3 tasks

Missing guards after argparse for bad arg combinations #211

madeddy opened this issue Apr 1, 2024 · 1 comment

Comments

@madeddy
Copy link
Contributor

madeddy commented Apr 1, 2024

(Tracking issue to have it noted and don't gets forgotten.)

At the moment, as of unrpyc v2.0 / v1.3, its possible to use certain argparse arg combinations which will not work and fail mostly silently. This includes TL issues like mentioned in #202, but some can be there resolved with the described refactoring.

Known bad combis:

  • no_pyexpr and comparable args without dump (mentioned but not blocked from usage)
  • translation args with dump or deobfuscation
  • combinations of translation args with each other

If someone knows more bad combinations just drop them here. So far... Guards for this already done, in testing and will be at some point added.

@madeddy
Copy link
Contributor Author

madeddy commented Apr 16, 2024

combinations of translation args with each other

This will not possible anymore if the translate PR gets merged so i close this issue as concluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant