Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth plane clipping #8203

Closed
wants to merge 1 commit into from
Closed

Fix depth plane clipping #8203

wants to merge 1 commit into from

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Sep 20, 2019

Fixes #7879. Merge #8207 first.

Pushes the depth plane farther from the camera so that the depth plane does not render above primitives in the scene.

This is a lot like existing code that used to push the depth plane below classification primitives to avoid rendering artifacts. 1fda8c0

Don't merge until #8179 is fixed, otherwise pickPosition will be extremely wrong when scene.depthTestAgainstTerrain is false.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Sep 23, 2019

@lilleyse who should review this, @IanLilleyT?

@simonasdmd
Copy link

@lilleyse Hello. Could you please look at this question? 8181

@cesium-concierge
Copy link

Thanks again for your contribution @lilleyse!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@cesium-concierge
Copy link

Thanks again for your contribution @lilleyse!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@lilleyse
Copy link
Contributor Author

Closing this, it's too Earth-centric. A better approach will involving finding the min/max heights based on the loaded terrain tiles / 3D Tiles kind of like #8398

@lilleyse lilleyse closed this Nov 25, 2019
@lilleyse lilleyse deleted the lower-depth-plane branch November 25, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depth plane causing clipping artifact
5 participants