Do not reload installed packages on file change #842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #790 .
The issue was present when the venv was created in the same dir as the project using chainlit. On reload the code that was supposed to clear the modules related to the app from
sys.modules
also cleared chainlit itself which led to a reload and a new config object being initialized whenconfig.py
module was loaded. Thesocket.py
module still had the reference to the old config module though, which resulted in reload failing. The lesson here is - module reloading in python is HARD and should really not be attempted. ;)The fix checks where the modules are installed (venv or regular installation) and prevents their reload. This fixes all cases EXCEPT the
hello.py
in the chainlit repo - as the chainlit code is in the same dir as the demo file it's imporsible to say what's what. A possible fix would be to movehello.py
to a subdir.