Add ability to get the aggsig additional data from full node RPC #17241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Despite the branch name, this code no longer adds the ability to melt CATs |
matt-o-how
added
CLI
Changed
Quexington
requested changes
Jan 8, 2024
Pull Request Test Coverage Report for Build 7463825691Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Quexington
approved these changes
Jan 9, 2024
arvidn
approved these changes
Jan 9, 2024
mikehw
pushed a commit
to mikehw/chia-blockchain
that referenced
this pull request
Jan 11, 2024
…a-Network#17241) * add melting related function rpc api * add rpc_client version of new functions * add get_additional_data to rpc and test it * remove melt_cats * remove cat_set_tail * black * lint fix * rpc_client returns bytes32 * black test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This adds in the ability to request a full node to tell you what the additional data required for an aggsig_me is.
This makes it easier for people to create applications which support use in the full node and create signatures to work on testnet, simulator, mainnet, and even other chia forks.
Current Behavior:
Function does not currently exist.
New Behavior:
Added
get_aggsig_additional_datato both RPC API and RPC Client.Testing Notes:
Added a line of test in to RPC tests.