Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Lane Arrows Buttons #387

Closed
wants to merge 4 commits into from

Conversation

kvakvs
Copy link
Collaborator

@kvakvs kvakvs commented Jun 22, 2019

Modifies Lane Arrow GUI to contain larger buttons with graphics for ON and OFF for each direction.
P.S. Blue text was temporary it is white again.

image

@FireController1847
Copy link
Collaborator

FireController1847 commented Jun 22, 2019

Is it just me or do these buttons look really tacky? They're very... THICK. Can we try making them a little thinner? Or maybe even just match the road texture?

@kvakvs
Copy link
Collaborator Author

kvakvs commented Jun 22, 2019

@FireController1847 you're welcome to suggest better graphics. I am not 100% happy with the disabled lane arrows.

@FireController1847 FireController1847 added enhancement Improve existing feature LABS TM:PE LABS branch STABLE TM:PE STABLE branch UI User interface updates labels Jun 22, 2019
@kvakvs
Copy link
Collaborator Author

kvakvs commented Jun 22, 2019

image

@originalfoo
Copy link
Member

The second image (comment above) looks vastly improved, and hugely better than current TMPE UI for that feature. Do we need the lane numbers? It's pretty obvious that there is a set of arrows per lane.

@kvakvs
Copy link
Collaborator Author

kvakvs commented Jun 22, 2019

It turns out we absolutely don't need "Lane" + i titles
image

@dymanoid
Copy link
Contributor

dymanoid commented Jun 23, 2019

Just a thought. Can we disable/hide buttons for invalid/senseless configurations?

Like:
lanes

If I select "middle lane straight and right", it shouldn't be possible to select "straight and left" for the right lane and "right" for the left lane, because intersections occur.

And maybe also hide "left" for the left lane when there's nowhere to turn left - like in the example above.

@FireController1847 FireController1847 self-assigned this Jun 23, 2019
@FireController1847 FireController1847 added this to the 11.1 milestone Jun 23, 2019
@kvakvs
Copy link
Collaborator Author

kvakvs commented Jun 24, 2019

The buttons should not disappear. Maybe empty buttons instead?

p.s. I am working on GUI which is rendered in the ground plane, it might become a much better replacement for lane arrows GUI than this branch.

@originalfoo
Copy link
Member

Removal of buttons looks weird. Maybe still have the arrow, greyed out, with no button background?

@kvakvs Regarding the GUI rendered on ground plane, that's certainly the direction we want to head in, but be aware there are some weird pitfalls and potential performance issues with that (see PR #282 for examples).

@kvakvs
Copy link
Collaborator Author

kvakvs commented Jun 24, 2019

@aubergine10 The world space UI is rendered via Canvas, i.e. it is constructed once to be a part of the scene, not an overlay rendered every frame. Unity handles that kind of rendering better.

@originalfoo
Copy link
Member

Is it worth closing this PR considering #391 ?

@kvakvs
Copy link
Collaborator Author

kvakvs commented Jun 26, 2019

I think so, canvas are the future

@originalfoo
Copy link
Member

Made obsolete by #391

@originalfoo originalfoo removed this from the 11.1 milestone Aug 12, 2019
@originalfoo originalfoo added the LANE ROUTING Feature: Lane arrows / connectors label Aug 13, 2019
@originalfoo originalfoo added this to the Abandoned milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature LABS TM:PE LABS branch LANE ROUTING Feature: Lane arrows / connectors STABLE TM:PE STABLE branch UI User interface updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants