Aerosol constructor changes #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
force-pushed
the
aj/named_tuple_cm2_evap
branch
2 times, most recently
from
79d6cc9
to
1d34f90
Compare
trontrytel
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 94.94% 94.87% -0.08%
==========================================
Files 36 36
Lines 1386 1386
==========================================
- Hits 1316 1315 -1
- Misses 70 71 +1
|
trontrytel
force-pushed
the
aj/named_tuple_cm2_evap
branch
from
7571606
to
26351ea
Compare
trontrytel
changed the title
sajjadazimi
reviewed
May 9, 2024
nefrathenrici
approved these changes
May 9, 2024
trontrytel
force-pushed
the
aj/named_tuple_cm2_evap
branch
from
012fc30
to
b4a8a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some changes in aerosol size distribution constructors that I needed in order to be able to broadcast in KinematicDriver.
I don't understand why, but it broke the ARG calibration test. @nefrathenrici, @sajjadazimi or @edejong-caltech - could I ask you to take a look? I'm not very familiar with that test. The ARG tests themselves seem fine, so maybe it's just something with the setup?
Aside from that I think that my life in KinematicDriver would be easier if rain_evaporation in 2-moment microphysics was returning a named tuple. So I changed that also.