Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pillow crop entry #4640

Merged
merged 14 commits into from
Jun 7, 2024
Merged

Conversation

seaboundavian
Copy link
Contributor

@seaboundavian seaboundavian commented May 12, 2024

Description

Added a term entry for the .crop() method into a file crop.md with the directory specified on the issue page. .../content/pillow did not exist yet so I created it.

This entry covers the syntax, the arguements and their usage, and provides an example. As the Pillow library works with images, an image was included in the example to show the original and output image. The provided Term Entry Template was used and I followed the style guide to the best of my ability.

Issue Solved

Closes #4622

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

Initial Commit containing first draft.
Add Media to show results of crop.
@CLAassistant
Copy link

CLAassistant commented May 12, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this May 12, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed pillow Python:Pillow entries labels May 12, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @seaboundavian! Thank you for contributing to Codecademy docs! The entry was well written!

I've suggested some changes, could you please review and modify those at your earliest convenience? Please feel free to discuss if you have any concerns.
Thank you!

content/pillow/concepts/image/terms/crop/crop.md Outdated Show resolved Hide resolved
content/pillow/concepts/image/terms/crop/crop.md Outdated Show resolved Hide resolved
content/pillow/concepts/image/terms/crop/crop.md Outdated Show resolved Hide resolved
content/pillow/concepts/image/terms/crop/crop.md Outdated Show resolved Hide resolved
content/pillow/concepts/image/terms/crop/crop.md Outdated Show resolved Hide resolved
content/pillow/concepts/image/terms/crop/crop.md Outdated Show resolved Hide resolved
content/pillow/concepts/image/terms/crop/crop.md Outdated Show resolved Hide resolved
seaboundavian and others added 8 commits May 13, 2024 00:03
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
@seaboundavian
Copy link
Contributor Author

Hello!

I believe I've met all the suggested changes and ready for a re-review. Thanks.

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the required changes @seaboundavian!

Looks good for the second review 👍

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @seaboundavian!

The PR will be merged soon. 👍

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 17, 2024
@Sriparno08 Sriparno08 merged commit c327621 into Codecademy:main Jun 7, 2024
6 checks passed
Copy link

github-actions bot commented Jun 7, 2024

👋 @seaboundavian
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pillow/image/crop

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python pillow .crop()
4 participants