-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pillow crop entry #4640
New pillow crop entry #4640
Conversation
Initial Commit containing first draft.
Add Media to show results of crop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @seaboundavian! Thank you for contributing to Codecademy docs! The entry was well written!
I've suggested some changes, could you please review and modify those at your earliest convenience? Please feel free to discuss if you have any concerns.
Thank you!
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Co-authored-by: Mamta Wardhani <53176352+mamtawardhani@users.noreply.github.com>
Hello! I believe I've met all the suggested changes and ready for a re-review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the required changes @seaboundavian!
Looks good for the second review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @seaboundavian!
The PR will be merged soon. 👍
👋 @seaboundavian 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/pillow/image/crop Please note it may take a little while for changes to become visible. |
Description
Added a term entry for the
.crop()
method into a filecrop.md
with the directory specified on the issue page. .../content/pillow did not exist yet so I created it.This entry covers the syntax, the arguements and their usage, and provides an example. As the
Pillow
library works with images, an image was included in the example to show the original and output image. The provided Term Entry Template was used and I followed the style guide to the best of my ability.Issue Solved
Closes #4622
Type of Change
Checklist
main
branch.Issues Solved
section.