Modified default value of http_generated_images_dir to fall back to generated_images_dir instead of http_images_dir. #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generated_images_dir instead of http_images_dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation indicates that http_generated_images_path if unset should default to http_path + generated_images_dir. The current behavior, however, is for http_generated_images_path to default to http_images_path. If generated_images_dir is changed, http_generated_images_path does not change. This patch changes the default value of http_generated_images_dir to correspond with the documentation.
Existing configurations that rely on changes to http_images_path to affect the default value of http_generated_images_path are incompatible with this change, however, it is more useful to maintain the logical correspondence between http_generated_images_path and generated_images_dir, which is specified by the current documentation.