Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Don't strip whitespace from submissions #1883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quantum5
Copy link
Member

@quantum5 quantum5 commented Mar 5, 2022

This could be beneficial to TEXT submissions and would have been useful for certain languages that required line numbers to be indented and aligned. However, this is a significant behaviour change and deserves some scrutiny.

@codecov-commenter
Copy link

Codecov Report

Merging #1883 (017503f) into master (0a8e3cf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1883   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files         231      231           
  Lines       13054    13054           
=======================================
  Hits         6037     6037           
  Misses       7017     7017           
Impacted Files Coverage Δ
judge/forms.py 44.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8e3cf...017503f. Read the comment docs.

@Riolku
Copy link
Contributor

Riolku commented Mar 5, 2022

Maybe a silly suggestion, but could we fix a smaller issue and only not strip the trailing NL?

@quantum5
Copy link
Member Author

quantum5 commented Apr 3, 2022

Maybe a silly suggestion, but could we fix a smaller issue and only not strip the trailing NL?

No. You don't want COBOL users to fail to compile if they insist on writing old style with the line numbers, do you?

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any problems that rely on this old behaviour? There are some problems with custom graders where we've had to override the behaviour of TEXT so that it includes the trailing newline, but I can't think of any were we want this current behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants