renderer: expression_t is always allocated as part of structs, ext->numOps always 0 if ext is invalid #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
force-pushed
the
illwieckz/simplify-expression
branch
2 times, most recently
from
c906c30
to
40bf242
Compare
illwieckz
force-pushed
the
illwieckz/simplify-expression
branch
3 times, most recently
from
efe082c
to
0a88dba
Compare
slipher
reviewed
Apr 30, 2024
|
|
||
| // A ext->numOps equals to 0 means empty or invalid expression. |
There was a problem hiding this comment.
Suggesting there is such a thing as a valid empty expression, but I don't suppose that's the case?
There was a problem hiding this comment.
Maybe an empty expression is invalid, right.
There was a problem hiding this comment.
I took a closer look and in fact there are "valid" empty expressions, because the parser is buggy, e.g. ((())). Apparently they evaluate to 0. It's not something that should have been accepted though.
illwieckz
commented
Apr 30, 2024
illwieckz
force-pushed
the
illwieckz/simplify-expression
branch
from
c125b4d
to
64587e1
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know,
expression_tis always allocated as part of structs (texModInfo_t,shaderStage_t),ext->numOpsis always0ifextis invalid.