Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetics] support http_version in multi-step API tests #2323

Merged
merged 1 commit into from Mar 19, 2024

Conversation

etnbrd
Copy link
Contributor

@etnbrd etnbrd commented Mar 15, 2024

This PR adds the support for the http_version option for http step in multi-step API tests.

@etnbrd etnbrd force-pushed the etnbrd/SYNTH-13257/http_version branch 3 times, most recently from d9f1bd8 to ad31749 Compare March 15, 2024 20:01
@etnbrd etnbrd force-pushed the etnbrd/SYNTH-13257/http_version branch from ad31749 to 16b0027 Compare March 15, 2024 21:12
@etnbrd etnbrd marked this pull request as ready for review March 15, 2024 21:34
@etnbrd etnbrd requested review from a team as code owners March 15, 2024 21:34
@etnbrd etnbrd changed the title [SYNTH-13257] support http_version in multi-step API tests [synthetics] support http_version in multi-step API tests Mar 15, 2024
Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,7 +1,7 @@
module github.com/terraform-providers/terraform-provider-datadog

require (
github.com/DataDog/datadog-api-client-go/v2 v2.24.0
github.com/DataDog/datadog-api-client-go/v2 v2.24.1-0.20240313200128-5ad8b96de316
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this temporary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is temporary and fine to do. We will pin the client to an official released version before releasing the provider

@skarimo skarimo merged commit b13194e into master Mar 19, 2024
13 of 15 checks passed
@skarimo skarimo deleted the etnbrd/SYNTH-13257/http_version branch March 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants