[WIP] implement buffer listener to start serve http after boot finished
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorilla001
commented
Sep 7, 2017
gorilla001
commented
- 启动后阻塞http请求至调度器完成第一次task reconcile之后才开始处理
gorilla001
force-pushed
the
listenbuffer
branch
from
55daf81
to
7061eee
Compare
bbklab
reviewed
Sep 8, 2017
manager/manager.go
Outdated
| case LeadershipFollower: | ||
| log.Warnln("became follower, closing all agents ...") | ||
| m.clusterMaster.CloseAllAgents() | ||
| m.apiserver.UpdateLeader(m.leader) | ||
|
|
||
| close(m.activator) // notify apiserver to serve | ||
| } |
There was a problem hiding this comment.
potential panic: close of closed channel ？
bbklab
reviewed
Sep 8, 2017
manager/tcpmux.go
Outdated
| return &muxListener{ | ||
| pool: m.poolMole, | ||
| pool: m.poolMole, | ||
| activate: activate, | ||
| } |
bbklab
reviewed
Sep 8, 2017
manager/manager.go
Outdated
| @@ -29,6 +29,8 @@ type Manager struct { | |||
| electRootPath string | |||
| leader string | |||
| myid string | |||
| activator chan struct{} | |||
| notify chan struct{} | |||
There was a problem hiding this comment.
notify chan 感觉不需要，直接传递 activator chan 好了
gorilla001
force-pushed
the
listenbuffer
branch
from
bb27bd3
to
17b23f5
Compare
gorilla001
force-pushed
the
listenbuffer
branch
from
17b23f5
to
b7cd475
Compare
|
need rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.