Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pyrodigal as Prodigal alternative #456

Open
lfenske-93 opened this issue Dec 5, 2022 · 2 comments
Open

Use Pyrodigal as Prodigal alternative #456

lfenske-93 opened this issue Dec 5, 2022 · 2 comments
Labels
enhancement Proposed feature or change to GTDB-Tk.

Comments

@lfenske-93
Copy link
Contributor

Hi,

Since GTDBtk is using Prodigal, I was wondering if maybe you have thought about switching to Pyrodigal?

In case you haven't came across the Prodigal bug yet: A typo in the node scoring function causes Prodigal to apply a score penalty to any candidate gene located on the reverse strand. It's patched already, but there's no official patch release: hyattpd/Prodigal#88

I think since release 2.0.0 Pyrodigal is a reliable, faster and most important actively maintained version of or successor to Prodigal.

You might want to think about giving it a try. 😉

Greetings,
Linda

@donovan-h-parks
Copy link
Collaborator

Hi Linda,

Thank you for bringing this to our attention. We are investigating further. Do you have any sense of how much this bug impacts Prodigal results?

Cheers,
Donovan

@lfenske-93
Copy link
Contributor Author

Hi Donovan,

as far as I know it affects the overall gene prediction, so that some genes are predicted in the wrong places and others may not be predicted at all.

We stumbled across this some time ago and one of my colleagues then made a major comparison between Prodigal and Pyrodigal: https://github.com/jhahnfeld/prodigal-pyrodigal-comparison

It is definitely worth taking a closer look at Pyrodigal, as it is becoming more and more popular, many people and tools are currently switching to it.

Greetings,
Linda

@pchaumeil pchaumeil added the enhancement Proposed feature or change to GTDB-Tk. label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposed feature or change to GTDB-Tk.
Projects
None yet
Development

No branches or pull requests

3 participants