Add test for subtype property returning string in 1.9

Elgg · Jan 16, 2013 · 41fbc06 · 41fbc06
1 parent f84df1f
commit 41fbc06
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/engine/classes/ElggEntity.php b/engine/classes/ElggEntity.php
@@ -177,8 +177,6 @@ public function __clone() {
 	 *
 	 * @todo What problems are these?
 	 *
-	 * @warning Subtype is returned as an id rather than the subtype string. Use getSubtype()
-	 * to get the subtype string.
 	 *
 	 * @param string $name Name
 	 *

diff --git a/engine/tests/ElggCoreEntityTest.php b/engine/tests/ElggCoreEntityTest.php
@@ -83,6 +83,18 @@ public function testElggEntityGetAndSetBaseAttributes() {
 		$this->assertIdentical($this->entity->getTimeUpdated(), $this->entity->time_updated );
 	}
 
+	public function testElggEntitySubtypePropertyReturnsString() {
+		$test_subtype = 'test_subtype';
+		$obj = new ElggObject();
+		$obj->subtype = $test_subtype;
+		$guid = $obj->save();
+
+		invalidate_cache_for_entity($guid);
+
+		$obj = get_entity($guid);
+		$this->assertEqual($obj->subtype, $test_subtype);
+	}
+
 	public function testElggEntityGetAndSetMetaData() {
 		// ensure metadata not set
 		$this->assertNull($this->entity->get('non_existent'));