Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating esptool shipped with EmotiBit firmware installer #200

Merged
merged 2 commits into from Apr 20, 2023

Conversation

nitin710
Copy link
Collaborator

@nitin710 nitin710 commented Apr 20, 2023

Description

  • The esptool currently being shipped with EmotiBit FirmwareInstaller for macos is breaking for later version of macos (big sur and above, specifically versions released after M1 macs)
  • Here is a link to the error seen on the console
  • According to our documentation, we have been using esptool v3.3, but there are no developer notes specifying where the esptool binary was obtained from.
  • The binary obtained form the esptool release page, is tested working with the following OS and hence is being shipped with the new firmware installer.
    • macOS mojave (Previous version of firmware installer was working without any issues)
    • macOS Big Sur
    • macOS Monterey

Requirements

  • None

Issues Referenced

Documentation update

None.

Notes for Reviewer

  • None

Testing

Results

macOS version Firmware Installer output EmotiBit serial output
macOS Mojave Screen Shot 2023-04-20 at 4 34 23 PM -
macOS Big Sur Screen Shot 2023-04-20 at 4 16 02 PM image
macOS Monterey Screen Shot 2023-04-20 at 4 34 23 PM image

Unit Tests

  • Firmware Installer uploads correct firmware

Steps to test

  • Run the firmware installer on the test machine.
  • Verify the firmware is correctly installed using serial output.

Screenshots:

@nitin710 nitin710 merged commit 3494df5 into master Apr 20, 2023
@nitin710 nitin710 deleted the hotfix-esptoolForMac branch April 20, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note about origin of esptool binaries in readme
1 participant