Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix typos #284

wants to merge 1 commit into from

Conversation

maximus2600
Copy link

mistralrs_server should be mistralrs-server

@EricLBuehler
Copy link
Owner

I think that we do this intentionally, to avoid a conflict? When we copy the binary out, the folder mistralrs-server conflicts with the filename mistralrs-server so it does not put it in the correct location. By using mistralrs_server it just copies it. Do you have a better name idea?

@maximus2600
Copy link
Author

Ah I missed the step cp ./target/release/mistralrs-server ./mistralrs_server, IMHO - and _ and got me confused.
Maybe the directories could be just named bench, core, lora, pyo3 and server? Maybe mistralrs-* is a bit redundant since they all reside in the directoy mistral-rs.

Just my 2 cents.

@EricLBuehler
Copy link
Owner

The convention of project-subfolder is a Rust convention unfortunately. Maybe we could copy it out to server: cp ./target/release/mistralrs-server ./server`?

@EricLBuehler EricLBuehler added the documentation Improvements or additions to documentation label May 10, 2024
Copy link

Code Metrics Report
  ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 Dockerfile              1           34           25            0            9
 Happy                   1          442          369            0           73
 JSON                    5            9            9            0            0
 Python                 21          741          622           21           98
 TOML                   15          390          352            1           37
-------------------------------------------------------------------------------
 Jupyter Notebooks       1            0            0            0            0
 |- Markdown             1           60           30           22            8
 |- Python               1           96           87            1            8
 (Total)                            156          117           23           16
-------------------------------------------------------------------------------
 Markdown               15         1026            0          758          268
 |- BASH                 6          205          192            0           13
 |- Python               6          121          110            0           11
 |- Rust                 3          185          172            9            4
 (Total)                           1537          474          767          296
-------------------------------------------------------------------------------
 Rust                   80        26617        24483          340         1794
 |- Markdown            38          382            0          377            5
 (Total)                          26999        24483          717         1799
===============================================================================
 Total                 140        29259        25860         1120         2279
===============================================================================
  

@EricLBuehler
Copy link
Owner

Hi @maximus2600!

I agree that calling it mistralrs_server is a bit redundant. Can you please rename the occurrences (I think there's also a typo mitralrs_server) to server? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants