Feature: fix a number of redirect handling issues #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeybaker
approved these changes
May 10, 2022
| if (res.statusCode === 301 || res.statusCode === 302 || res.statusCode === 307) { | ||
| if (!res.headers.location) { | ||
| // Server sent redirect response without Location header. | ||
| _emit('error', new Event('error', {status: res.statusCode, message: res.statusMessage})) |
There was a problem hiding this comment.
I think this isn't important, but we are loosing this error reporting. Probably fine?
rexxars
changed the title
I don't think there should be any config changes necessary, but given I am not 100% sure, I agree with your point. Given this is patching a security issue, I really want to get a patch release out to ensure people don't have to upgrade to a new major to be covered. I have opened #273 to address only the headers issue, leaving this one as a general redirect handling PR. Would you mind reviewing that one, @joeybaker ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting an eventsource endpoint and defining custom, sensitive headers, such as
AuthorizationandCookie, these headers should not be forwarded when redirecting to a different origin than the original.While looking in to fixing this, I discovered that the current redirect handling also does not support relative URLs in the
Locationheader (egLocation: /some/other/path), nor does it set any limit on the maximum number of redirects. Instead of attempting to patch all these shortcomings, I feel we are better suited by utilizing the follow-redirects module, which handles all of these cases and is widely used.