Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid negative integer overflow when iccOffset > chunkLength #795

Merged
merged 1 commit into from May 5, 2019
Merged

Avoid negative integer overflow when iccOffset > chunkLength #795

merged 1 commit into from May 5, 2019

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes #790.

@kevinbackhouse kevinbackhouse changed the title Avoid negative integer overflow when (iccOffset > chunkLength Avoid negative integer overflow when iccOffset > chunkLength Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019 •
edited

Codecov Report

Merging #795 into 0.27-maintenance will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           0.27-maintenance     #795      +/-   ##
====================================================
+ Coverage             62.67%   62.67%   +<.01%     
====================================================
  Files                   156      156              
  Lines                 21523    21524       +1     
====================================================
+ Hits                  13490    13491       +1     
  Misses                 8033     8033
Impacted Files Coverage Δ
src/pngimage.cpp 80.75% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79af9f...709830d. Read the comment docs.

@D4N D4N added the to-master label Apr 25, 2019
D4N
D4N previously requested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've added some minor suggestions and one info that needn't be addressed now.

tests/bugfixes/github/test_issue_790.py Outdated Show resolved Hide resolved
tests/bugfixes/github/test_issue_790.py Outdated Show resolved Hide resolved
src/pngimage.cpp Outdated Show resolved Hide resolved
tests/bugfixes/github/test_issue_790.py Outdated Show resolved Hide resolved
@kevinbackhouse kevinbackhouse force-pushed the bugfix_790_PngImage_readMetadata branch 2 times, most recently from 6710899 to cffac6e Compare April 25, 2019 20:32
@clanmills clanmills added this to the v0.27.2 milestone Apr 30, 2019
@kevinbackhouse kevinbackhouse force-pushed the bugfix_790_PngImage_readMetadata branch from b0b81ab to 709830d Compare May 2, 2019 09:18
@piponazo piponazo self-requested a review May 5, 2019 05:18
piponazo
piponazo approved these changes May 5, 2019
View reviewed changes
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@D4N the two changes you requested were addressed, so I guess you can approve now 😉

@piponazo piponazo requested a review from D4N May 5, 2019 05:18
@D4N
Copy link
Member

D4N commented May 5, 2019

Lgtm, please merge this! (Cannot approve right now)

@piponazo piponazo dismissed D4N’s stale review May 5, 2019 10:15

So I can merge without changing repo setup

@piponazo piponazo merged commit 6fa2e31 into Exiv2:0.27-maintenance May 5, 2019
@mergify mergify bot mentioned this pull request May 5, 2019
Merged
@kevinbackhouse kevinbackhouse deleted the bugfix_790_PngImage_readMetadata branch September 18, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo piponazo approved these changes

@D4N D4N Awaiting requested review from D4N

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.27.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinbackhouse @D4N @piponazo @clanmills