Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'_original_params' can be None #981

Merged
merged 1 commit into from
Dec 7, 2022
Merged

'_original_params' can be None #981

merged 1 commit into from
Dec 7, 2022

Conversation

foarsitter
Copy link
Contributor

@foarsitter foarsitter commented Oct 23, 2022 •
edited

Modified this pull request so it solves #979

@foarsitter foarsitter mentioned this pull request Oct 23, 2022
Open
kingbuzzman
kingbuzzman reviewed Oct 28, 2022
View reviewed changes
factory/django.py Show resolved Hide resolved
tests/test_django.py Outdated Show resolved Hide resolved
factory/django.py Show resolved Hide resolved
@kingbuzzman
Copy link
Contributor

@foarsitter can you sync/rebase your branch with factory_boy:master, there are CI fixes you don't have.

kingbuzzman
kingbuzzman reviewed Oct 28, 2022
View reviewed changes
tests/djapp/models.py Outdated Show resolved Hide resolved
@foarsitter @kingbuzzman
Add extra check if _original_params is not None and validate with a t…
eb2eac1 
…estcase for django

Co-authored-by: Javier Buzzi <buzzi.javier@gmail.com>
@foarsitter foarsitter changed the title Add test case to demonstrate "has no attribute '_original_params'" '_original_params' can be None Oct 28, 2022
@foarsitter foarsitter mentioned this pull request Nov 15, 2022
Closed
francoisfreitag
francoisfreitag approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the ideal fix, but it does make things better and is easy to improve upon.

@francoisfreitag francoisfreitag merged commit 3f4c2dc into FactoryBoy:master Dec 7, 2022
@foarsitter foarsitter deleted the testcase_original_params branch December 19, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingbuzzman kingbuzzman kingbuzzman left review comments

@francoisfreitag francoisfreitag francoisfreitag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@foarsitter @kingbuzzman @francoisfreitag