Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): preserve special characters #257

Merged
merged 2 commits into from May 14, 2024
Merged

Conversation

FalcoSuessgott
Copy link
Owner

@FalcoSuessgott FalcoSuessgott commented May 11, 2024

fixes #255

@FalcoSuessgott FalcoSuessgott changed the title fix(export): preserver special characters fix(export): preserve special characters May 11, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.32%. Comparing base (6b528bc) to head (558cf8f).
Report is 84 commits behind head on master.

Files Patch % Lines
pkg/utils/utils.go 75.00% 1 Missing and 1 partial ⚠️
pkg/printer/secret/base.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   69.59%   71.32%   +1.73%     
==========================================
  Files          29       35       +6     
  Lines        1322     1566     +244     
==========================================
+ Hits          920     1117     +197     
- Misses        290      313      +23     
- Partials      112      136      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

gitguardian bot commented May 14, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@FalcoSuessgott FalcoSuessgott merged commit 75f83b2 into master May 14, 2024
7 checks passed
@FalcoSuessgott FalcoSuessgott deleted the json_encoding branch May 14, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret Values special characters are interpreted
1 participant