New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong number of arguments #671
Conversation
WalkthroughThe update made to the script involves a simplification in the handling of environment variables passed to the Redis server command. The modification ensures that the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (3)
build/docker/run.sh (3)
Line range hint
1-1
: Add a shebang to specify the shell interpreter.+ #!/bin/bash
Line range hint
3-3
: Consider quoting${BROWSER:-1}
to prevent globbing and word splitting.- if [ ${BROWSER:-1} -eq 1 ] + if [ "${BROWSER:-1}" -eq 1 ]
Line range hint
20-20
: Quote the variables in the Redis server command to prevent issues.- redis-server --protected-mode no ${REDIS_ARGS} \ - --loadmodule ${MODULE_DIR}/falkordb.so ${FALKORDB_ARGS:-""} + redis-server --protected-mode no "${REDIS_ARGS}" \ + --loadmodule "${MODULE_DIR}/falkordb.so" "${FALKORDB_ARGS:-""}"
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- build/docker/run.sh (1 hunks)
Additional Context Used
ShellCheck (7)
build/docker/run.sh (7)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
[info] 3-3: Double quote to prevent globbing and word splitting.
[info] 11-11: Double quote to prevent globbing and word splitting.
[info] 14-14: Double quote to prevent globbing and word splitting.
[info] 20-20: Double quote to prevent globbing and word splitting.
[info] 22-22: Double quote to prevent globbing and word splitting.
[info] 23-23: Double quote to prevent globbing and word splitting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
build/docker/run.sh (1)
Line range hint
1-1
: Add a shebang to specify the shell interpreter.+ #!/bin/bash
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- build/docker/run.sh (1 hunks)
Additional Context Used
ShellCheck (7)
build/docker/run.sh (7)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
[info] 3-3: Double quote to prevent globbing and word splitting.
[info] 11-11: Double quote to prevent globbing and word splitting.
[info] 14-14: Double quote to prevent globbing and word splitting.
[info] 20-20: Double quote to prevent globbing and word splitting.
[info] 22-22: Double quote to prevent globbing and word splitting.
[info] 23-23: Double quote to prevent globbing and word splitting.
Additional comments not posted (4)
build/docker/run.sh (4)
11-11
: Ensure${TLS:-0}
is quoted to prevent globbing and word splitting.- if [ ${TLS:-0} -eq 1 ] + if [ "${TLS:-0}" -eq 1 ]
14-14
: Ensure all variables in the Redis server command are properly quoted to prevent globbing and word splitting.- redis-server --protected-mode no ${REDIS_ARGS} \ + redis-server --protected-mode no "${REDIS_ARGS}" \ --tls-port 6379 --port 0 \ --tls-cert-file ./tls/redis.crt \ --tls-key-file ./tls/redis.key \ --tls-ca-cert-file ./tls/ca.crt \ --tls-auth-clients no \ - --loadmodule ${MODULE_DIR}/falkordb.so ${FALKORDB_ARGS:-""} + --loadmodule "${MODULE_DIR}/falkordb.so" "${FALKORDB_ARGS:-""}"
20-20
: Ensure all variables in theloadmodule
command are properly quoted to prevent globbing and word splitting.- --loadmodule ${MODULE_DIR}/falkordb.so ${FALKORDB_ARGS} + --loadmodule "${MODULE_DIR}/falkordb.so" "${FALKORDB_ARGS}"
23-23
: Ensure all variables in theloadmodule
command are properly quoted to prevent globbing and word splitting.- --loadmodule ${MODULE_DIR}/falkordb.so ${FALKORDB_ARGS} + --loadmodule "${MODULE_DIR}/falkordb.so" "${FALKORDB_ARGS}"
Fix #669