Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "iff" typo and unpaired curly bracket in Javadoc #250

Closed
wants to merge 2 commits into from

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Apr 26, 2024

Analogous to FasterXML/jackson-databind#4502

Also took the liberty to remove the no-arg constructor via 5139004.

@pjfanning
Copy link
Member

-1 to mixing unrelated fixes in a PR

iff is a word - https://en.wiktionary.org/wiki/iff#:~:text=(mathematics%2C%20logic)%20Short%20for%20if%20and%20only%20if.

@Philzen
Copy link
Contributor Author

Philzen commented Apr 26, 2024

-1 to mixing unrelated fixes in a PR

Completely agree – i tend to hold it the same way, however different projects have different rules of engagement regarding this, and this being my first contribution to Jackson i thought i'd simply await your advise. Moved the commit over to #251.

Concerning the main scope of this PR, i'm happy to follow whatever is decided in FasterXML/jackson-databind#4502

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here making "iff" simple "if" makes sense, and curly is indeed extraneous.

@cowtowncoder
Copy link
Member

Since PR is now split & changes make sense, LGTM.
Just need 2 things:

  1. Re-base against 2.18 (no benefit from backporting)
  2. CLA (as per my note on another issue)

and will merge.

@Philzen Philzen changed the title Fix "iff" typo and unpaired curly bracket in Javadoc, remove redundant no-arg constructor Fix "iff" typo and unpaired curly bracket in Javadoc Apr 27, 2024
@Philzen
Copy link
Contributor Author

Philzen commented Apr 28, 2024

@cowtowncoder CLA has been signed and sent.

I've now opened #252 for the 2.18 branch. Let me briefly explain the reasoning behind me initially starting with 2.15.

  1. i checked https://github.com/FasterXML/jackson/wiki/Jackson-Releases which lists 2.15 as "open branch". I guess i must have misunderstood this as "open for contributions" / "actively maintained" – though i understand 2.15 is now in maintenance mode, or even EOL, is it?
  2. Spring Boot (which probably is the biggest attractor bringing people into contact with Jackson for the first time – at least it was in my case) has 2.15.4 in their latest release. Even the upcoming 3.3.0 release of spring boot won't be shipping with 2.18, but 2.17.0 – but i now understand is the latest available release. That's why in my understanding that'd be that is minimum version to still support.

As said, i'm otherwise happy to backport any of my PRs to 2.17 and below.

@Philzen Philzen closed this Apr 28, 2024
@cowtowncoder
Copy link
Member

@Philzen ok: in this context "open branch" simply means that further releases might be made. It is also possible that the list may be out of date. But I can definitely see how this is confusing so I can see the reasoning behind selecting 2.15 for maximum benefit.

I'll see if I should update that Wiki page, regardless.

@Philzen Philzen deleted the 2-15-fix-typo-iff branch May 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants