-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "iff" typo and unpaired curly bracket in Javadoc #250
Conversation
-1 to mixing unrelated fixes in a PR iff is a word - https://en.wiktionary.org/wiki/iff#:~:text=(mathematics%2C%20logic)%20Short%20for%20if%20and%20only%20if. |
5139004
to
d0070ac
Compare
Completely agree – i tend to hold it the same way, however different projects have different rules of engagement regarding this, and this being my first contribution to Jackson i thought i'd simply await your advise. Moved the commit over to #251. Concerning the main scope of this PR, i'm happy to follow whatever is decided in FasterXML/jackson-databind#4502 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here making "iff" simple "if" makes sense, and curly is indeed extraneous.
Since PR is now split & changes make sense, LGTM.
and will merge. |
@cowtowncoder CLA has been signed and sent. I've now opened #252 for the 2.18 branch. Let me briefly explain the reasoning behind me initially starting with 2.15.
As said, i'm otherwise happy to backport any of my PRs to 2.17 and below. |
@Philzen ok: in this context "open branch" simply means that further releases might be made. It is also possible that the list may be out of date. But I can definitely see how this is confusing so I can see the reasoning behind selecting 2.15 for maximum benefit. I'll see if I should update that Wiki page, regardless. |
Analogous to FasterXML/jackson-databind#4502
Also took the liberty to remove the no-arg constructor via 5139004.