fix some of the tests broken with Java17 #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'll manually merge this to |
cowtowncoder
added a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3469
The remaining broken tests are related to java.lang.Record
The pom change is borrowed from #3549 (thanks to @sigpwned) - seems best to grab the pom change while rest of the PR is discussed.
See #3549 (comment) for list of broken tests (ones not fixed by this change - this change fixes about a dozen other test failures).
#3102 seems to be the issue that is breaking the Record tests. According to this medium article, this reflection support was hardened in Java 15. So the reflection field setter might have worked in Java 14 but has been broken since.