Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix header file include errors when compile integration_tests/main.cpp #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vacing
Copy link

@vacing vacing commented Apr 1, 2020

No description provided.

@CasparKielwein
Copy link
Member

CasparKielwein commented Apr 1, 2020

I'm willing to merge it.

But I wonder why the old state does not build in your setup. Are you building from an IDE?
cd build && cmake .. && make dummy_executable works for me.

@vacing
Copy link
Author

vacing commented Apr 2, 2020

I didn't use an IDE, but cmake.
I think maybe you install adobe/forest.hpp in your include path, so you can make it on your own computer.
It seems there is no question that something is wrong. The solution may be we modify cmake to put adobe/ on the root include path (this may also avoid file conflicts if we have anohter project use adobe/forest.hpp), or adopt the patch what I submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants