do not allow to delete properties in FeaturePythonPyT

FreeCAD · Nov 10, 2016 · 025cf18 · 025cf18
1 parent f345501
commit 025cf18
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/App/FeaturePythonPyImp.h b/src/App/FeaturePythonPyImp.h
@@ -24,7 +24,7 @@
 #define APP_FEATUREPYTHONPYIMP_H
 
 #include <Base/BaseClass.h>
-#include <Base/PyObjectBase.h>
+#include <App/PropertyContainerPy.h>
 
 namespace App
 {

diff --git a/src/App/FeaturePythonPyImp.inl b/src/App/FeaturePythonPyImp.inl
@@ -113,6 +113,12 @@ int FeaturePythonPyT<FeaturePyT>::__setattr(PyObject *obj, char *attr, PyObject
 template<class FeaturePyT>
 int FeaturePythonPyT<FeaturePyT>::_setattr(char *attr, PyObject *value)
 {
+    App::Property *prop = FeaturePyT::getPropertyContainerPtr()->getPropertyByName(attr);
+    if (prop && !value) {
+        PyErr_Format(PyExc_AttributeError, "Cannot delete attribute: '%s'", attr);
+        return -1;
+    }
+
     int returnValue = FeaturePyT::_setattr(attr, value);
     if (returnValue == -1) {
         PyObject* dict_item = value;