FEM: element flow 1D, deactivate not supported fluid types

FreeCAD · Jul 4, 2019 · 126cb43 · 126cb43
1 parent 217d96e
commit 126cb43
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/Mod/Fem/femguiobjects/_ViewProviderFemElementFluid1D.py b/src/Mod/Fem/femguiobjects/_ViewProviderFemElementFluid1D.py
@@ -277,6 +277,7 @@ def __init__(self, obj):
             QtCore.SIGNAL("cellChanged(int, int)"),
             self.pump_characteristics_changed
         )
+        # some fluid types deactivated since they are not implemented in ccx writer
         self.parameterWidget.cb_section_type.addItems(
             _FemElementFluid1D._FemElementFluid1D.known_fluid_types
         )

diff --git a/src/Mod/Fem/femobjects/_FemElementFluid1D.py b/src/Mod/Fem/femobjects/_FemElementFluid1D.py
@@ -33,7 +33,9 @@
 class _FemElementFluid1D:
     "The FemElementFluid1D object"
 
-    known_fluid_types = ['Liquid', 'Gas', 'Open Channel']
+    known_fluid_types = ['Liquid']
+    # 'Gas', 'Open Channel' are not impemented in ccx writer
+    # known_fluid_types = ['Liquid', 'Gas', 'Open Channel']
     known_liquid_types = [
         'PIPE MANNING',
         'PIPE ENLARGEMENT',

diff --git a/src/Mod/Fem/femsolver/calculix/writer.py b/src/Mod/Fem/femsolver/calculix/writer.py
@@ -817,10 +817,14 @@ def write_femelementsets(self, f):
                             material
                         )
                         section_geo = liquid_section_def(fluidsec_obj, section_type)
+                    '''
+                    # deactivate as it would result in section_def and section_geo not defined
+                    # deactivated in the App and Gui object and thus in the task panel as well
                     elif fluidsec_obj.SectionType == 'Gas':
                         section_type = fluidsec_obj.GasSectionType
                     elif fluidsec_obj.SectionType == 'Open Channel':
                         section_type = fluidsec_obj.ChannelSectionType
+                    '''
                     f.write(section_def)
                     f.write(section_geo)
                 elif 'shellthickness_obj'in ccx_elset:  # shell mesh