Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
App: implement the private class OriginExtension to simulate a geomet…
…ric group behaviour
- Loading branch information
Showing
2 changed files
with
40 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
229e8dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wwmayer Can you please explain the purpose of adding GeoFeatureGroupExtension to Origin this way? It's quite unnatural, and will cause error when opening new file in older FreeCAD. Although forward compatibility is not a first priority, it shouldn't be broken so easily. I see you made a follow up commit to bypass ExtensionContainer::Save(), which can solve the error reporting (although it's kinda unnatural as well), but you reverted it somehow? The point is, I can't see the reason why you need GeoFeatureGroupExtension here.