Skip to content

Commit

Permalink
FEM: Remove unnecessary overrides from Analysis
Browse files Browse the repository at this point in the history
onChanged, execute, mustExecute and getPyObject where overwritten but
the implementation didn't do anything different from the implementation
of the base class DocumentObject in this case. Thus they where
redundent.
  • Loading branch information
Markus Hovorka authored and berndhahnebach committed Sep 21, 2019
1 parent 9a82946 commit 27675f1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 27 deletions.
15 changes: 0 additions & 15 deletions src/Mod/Fem/App/FemAnalysis.cpp
Expand Up @@ -48,21 +48,6 @@ FemAnalysis::~FemAnalysis()
{
}

short FemAnalysis::mustExecute(void) const
{
return 0;
}

PyObject *FemAnalysis::getPyObject()
{
return App::DocumentObjectGroup::getPyObject();
}

void FemAnalysis::onChanged(const Property* prop)
{
App::DocumentObjectGroup::onChanged(prop);
}

void FemAnalysis::handleChangedPropertyName(Base::XMLReader &reader,
const char * TypeName,
const char *PropName)
Expand Down
15 changes: 3 additions & 12 deletions src/Mod/Fem/App/FemAnalysis.h
Expand Up @@ -43,23 +43,14 @@ class AppFemExport FemAnalysis : public App::DocumentObjectGroup
FemAnalysis(void);
virtual ~FemAnalysis();

/// returns the type name of the ViewProvider
virtual const char* getViewProviderName(void) const {
return "FemGui::ViewProviderFemAnalysis";
}
virtual App::DocumentObjectExecReturn *execute(void) {
return App::DocumentObject::StdReturn;
}
virtual short mustExecute(void) const;
virtual PyObject *getPyObject(void);

/// unique identifier of the Analysis
App::PropertyUUID Uid;

virtual const char* getViewProviderName() const {
return "FemGui::ViewProviderFemAnalysis";
}

protected:
/// get called by the container when a property has changed
virtual void onChanged (const App::Property* prop);
/// Support of backward compatibility
virtual void handleChangedPropertyName(Base::XMLReader &reader,
const char * TypeName,
Expand Down

0 comments on commit 27675f1

Please sign in to comment.