Path.Area: fixed handling of shape with placement

FreeCAD · Mar 23, 2017 · 31e82f0 · 31e82f0
1 parent 721a256
commit 31e82f0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 27 deletions.
diff --git a/src/Mod/Path/App/Area.cpp b/src/Mod/Path/App/Area.cpp
@@ -481,54 +481,42 @@ static int foreachSubshape(const TopoDS_Shape &shape, Func func, int type=TopAbs
 }
 
 struct FindPlane {
-    TopoDS_Shape &myShape;
+    TopoDS_Shape &myPlaneShape;
     gp_Trsf &myTrsf;
     double &myZ;
     FindPlane(TopoDS_Shape &s, gp_Trsf &t, double &z)
-        :myShape(s),myTrsf(t),myZ(z)
+        :myPlaneShape(s),myTrsf(t),myZ(z)
     {}
     void operator()(const TopoDS_Shape &shape, int) {
         gp_Trsf trsf;
+
         BRepLib_FindSurface finder(shape,-1,Standard_True);
         if (!finder.Found()) 
             return;
 
-        gp_Ax3 pos = GeomAdaptor_Surface(finder.Surface()).Plane().Position();
+        // NOTE: It seemed that FindSurface disregardge shape's transformation,
+        // so we have to transformed the found plane manually
+        gp_Ax3 pos = GeomAdaptor_Surface(finder.Surface()).Plane().Position().Transformed(
+                                    shape.Location().Transformation());
 
         //force plane to be right handed
         if(!pos.Direct())
             pos = gp_Ax3(pos.Ax2());
         gp_Dir dir(pos.Direction());
 
         trsf.SetTransformation(pos);
+
         if(fabs(dir.X())<Precision::Confusion() &&
             fabs(dir.Y())<Precision::Confusion()) 
         {
-            gp_Pnt origin = pos.Location();
-
-            // Probably another OCC bug, sometimes pos.Location().Z() for XY
-            // plane is stuck at zero, even though the plane is at above. So we
-            // double check the first vertex Z value
             TopExp_Explorer it(shape,TopAbs_VERTEX);
-            double z = BRep_Tool::Pnt(TopoDS::Vertex(it.Current())).Z();
-            if(fabs(origin.Z()-z)>Precision::Confusion()) {
-                AREA_WARN("XY plane has wrong Z height "<<origin.Z()<<", "<<z);
-                gp_Trsf trsf2;
-                trsf2.SetTranslationPart(gp_XYZ(0,0,origin.Z()-z));
-                trsf.Multiply(trsf2);
-            }
-            gp_Pnt pt = origin.Transformed(TopLoc_Location(trsf));
-            if(fabs(pt.X()) > Precision::Confusion() ||
-            fabs(pt.Y()) > Precision::Confusion() ||
-            fabs(pt.Z()) > Precision::Confusion()) {
-                AREA_WARN("wrong transformation "<<AREA_PT(pt));
-            }
-            if(!myShape.IsNull() && myZ > z)
+            const auto &pt = BRep_Tool::Pnt(TopoDS::Vertex(it.Current()));
+            if(!myPlaneShape.IsNull() && myZ > pt.Z())
                 return;
-            myZ = z;
-        }else if(!myShape.IsNull())
+            myZ = pt.Z();
+        }else if(!myPlaneShape.IsNull())
             return;
-        myShape = shape;
+        myPlaneShape = shape;
         myTrsf = trsf;
     }
 };

diff --git a/src/Mod/Path/App/FeatureArea.cpp b/src/Mod/Path/App/FeatureArea.cpp
@@ -114,9 +114,9 @@ App::DocumentObjectExecReturn *FeatureArea::execute(void)
 
     if(myShapes.empty())
         Shape.setValue(TopoDS_Shape());
-    else if(myShapes.size()==1)
-        Shape.setValue(myShapes.front());
     else{
+        // compound is built even if there is only one shape to save the
+        // trouble of messing around with placement
         BRep_Builder builder;
         TopoDS_Compound compound;
         builder.MakeCompound(compound);