[TD] - Fix geometry object leaking on every exec

FreeCAD · Feb 19, 2021 · 542bf23 · 542bf23
1 parent 17ec9b7
commit 542bf23
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/Mod/TechDraw/App/DrawViewPart.cpp b/src/Mod/TechDraw/App/DrawViewPart.cpp
@@ -298,11 +298,6 @@ App::DocumentObjectExecReturn *DrawViewPart::execute(void)
             double newScale = autoScale();
             Scale.setValue(newScale);
             Scale.purgeTouched();
-            if (geometryObject != nullptr) {
-                delete geometryObject;
-                geometryObject = nullptr;
-//                partExec(shape);
-            }
             partExec(shape);
         }
     }
@@ -348,6 +343,8 @@ void DrawViewPart::onChanged(const App::Property* prop)
 void DrawViewPart::partExec(TopoDS_Shape shape)
 {
 //    Base::Console().Message("DVP::partExec()\n");
+    if (geometryObject)
+        delete geometryObject;
     geometryObject = makeGeometryForShape(shape);
     if (geometryObject == nullptr) {
         return;